Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response status code to Resource Timing #34828

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 13, 2022

This CL introduces a responseStatus field to Performance Resource
Timing object. This field is behind a Runtime Enabled Flag.

Resource Timing PR : w3c/resource-timing#335
Fetch PR : whatwg/fetch#1468

Bug: 1343293
Change-Id: I60d1b6ba00f055481ca526a490144d88ddaf881b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3754923
Reviewed-by: Noam Rosenthal <[email protected]>
Commit-Queue: Abin Paul <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1040902}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3754923 branch 3 times, most recently from e2d3796 to f708ef5 Compare July 27, 2022 09:25
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3754923 branch 3 times, most recently from e80813b to a430edf Compare August 3, 2022 18:28
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3754923 branch 4 times, most recently from 6f1a7d4 to a3ce462 Compare August 21, 2022 12:41
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3754923 branch 4 times, most recently from 4fa5a46 to 53a0498 Compare August 30, 2022 10:10
This CL introduces a responseStatus field to Performance Resource
Timing object. This field is behind a Runtime Enabled Flag.

Resource Timing PR : w3c/resource-timing#335
Fetch PR : whatwg/fetch#1468

Bug: 1343293
Change-Id: I60d1b6ba00f055481ca526a490144d88ddaf881b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3754923
Reviewed-by: Noam Rosenthal <[email protected]>
Commit-Queue: Abin Paul <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1040902}
@WeizhongX
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/resource-timing/object-not-found-adds-entry.html Verify that a 200 null-typed object emits an entry. FAIL: 2/10, PASS: 8/10 assert_greater_than: encodedBodySize should be greater than 0 expected a number greater than 0 but got 0
/resource-timing/object-not-found-adds-entry.html Verify that a 404 null-typed object emits an entry. FAIL: 2/10, PASS: 8/10 assert_greater_than: encodedBodySize should be greater than 0 expected a number greater than 0 but got 0
/resource-timing/object-not-found-adds-entry.html Verify that a 404 img-typed object emits an entry. FAIL: 1/10, PASS: 9/10 assert_greater_than: encodedBodySize should be greater than 0 expected a number greater than 0 but got 0
/resource-timing/object-not-found-after-TAO-cross-origin-redirect.html   ERROR: 2/10, OK: 8/10  
/resource-timing/object-not-found-after-TAO-cross-origin-redirect.html There should be one entry. FAIL: 2/10, PASS: 8/10 assert_equals: There should be one entry. expected 1 but got 0
/resource-timing/object-not-found-after-TAO-cross-origin-redirect.html redirectStart > 0 in timing allowed cross-origin redirect. PASS: 8/10, MISSING: 2/10  
/resource-timing/object-not-found-after-TAO-cross-origin-redirect.html redirectStart == startTime in timing allowed cross-origin redirect. PASS: 8/10, MISSING: 2/10  
/resource-timing/object-not-found-after-TAO-cross-origin-redirect.html redirectEnd > redirectStart in timing allowed cross-origin redirect. PASS: 8/10, MISSING: 2/10  
/resource-timing/object-not-found-after-TAO-cross-origin-redirect.html fetchStart >= redirectEnd in timing allowed cross-origin redirect. PASS: 8/10, MISSING: 2/10  

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@nihardamar
Copy link
Contributor

bug https://bugs.chromium.org/p/chromium/issues/detail?id=1358295
@KyleJu can we admin merge this one?

@KyleJu KyleJu merged commit 9e8b0db into master Aug 30, 2022
@KyleJu KyleJu deleted the chromium-export-cl-3754923 branch August 30, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants