Screen orientation lock: remove bad 'hidden' tests #38511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
makotokato
requested changes
Feb 15, 2023
| @@ -14,48 +14,22 @@ | |||
|
|
|||
| promise_test(async (t) => { | |||
| const { minimize, restore } = window_state_context(t); | |||
| t.add_cleanup(restore); | |||
There was a problem hiding this comment.
window_state_context adds resotre() as clean up method. This is unnecessary. See #38031
function window_state_context(t) {
let rect = null;
let state = "restored";
t.add_cleanup(async () => {
if (state === "minimized")
await restore();
});I guess that you want to call orientation.unlcok as clean up. You should add t.add_cleanup(makeCleanup()); instead.
There was a problem hiding this comment.
Ah, thanks for checking that.
marcoscaceres
commented
Feb 16, 2023
marcoscaceres
commented
Feb 16, 2023
makotokato
approved these changes
Feb 17, 2023
marcoscaceres
added a commit
that referenced
this pull request
Mar 28, 2023
* Screen orientation lock: remove bad 'hidden' tests * Update screen-orientation/hidden_document.html * Update screen-orientation/hidden_document.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in w3c/screen-orientation#232