-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update accname/name/comp_labelledby.html with aria-labeledby [sic] tests #43698
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great investigation, Rahim. Thanks...
Hopefully stating the obvious that the non-standard spelling tests with different results should not land until the WG has had a chance to compare the results and come up with a general rule.
Some options:
- You could wait on the WG discussion in this PR (that might take a while), so the PR could get downstream conflicts (probably okay).
- You could commit the ones where the implementations agree, and file a second PR with the others.
- You could break the non-standard spelling tests into a standalone file: less likely to conflict, but more likely to get out of sync with the tests for the primary spelling.
If the WG decides this should be an allowed alternate spelling and otherwise behave the same as aria-labelledby, I think this PR is okay to land. However, it may be that the ARIA WG would not want it to conflict with some tests, such as the host language labeling mechanisms like label/for and alt. I don't know what the outcome will be.
@cookiecrook Got it, I'll hold onto this for the time being pending WG discussion and consensus. |
I wonder, in what ways does it matter if some browsers alias the "incorrect" spelling? It's probably okay that there's a test that points this specific use case out, mostly because it's a quirk (comparatively). JMO, though. I don't think I want spec to openly support both, but rather just know what a browser will do in either case, for this specific use case. |
@MelSumner FWIW, I agree. Fortunately, all browsers appear to prefer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit that added the ordered attribute changes is a good one long term, but will cause new failures in the Interop 2024 Focus Area. Those 3 new failing tests can either go in a tentative file, or in a later PR after Interop 2024 ends.
[Update: Actually I misread... Those are bad test expectations b/c it's accurate to use the correct spelling regardless of the order in which they appear.]
…nvalid misspelling.
WPT investigation for this issue: