Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move orphaned role tests to tentative. #46769

Merged

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook changed the title Move orphaned role tests to tenative. Move orphaned role tests to tentative. Jun 14, 2024
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate to push back after you did all this work, and ultimately I defer to you here, but I think make so many tentative files makes it hard to see how the the browsers are doing at a glance: https://wpt.fyi/results/wai-aria/role?label=pr_head&max-count=1&pr=46769

For this reason, I think one tentative file per directory might make more sense. It might also be less to maintain, if we want to move things from tentative back into the original test file.

But again, up to you, if you prefer the tests are organized this way -- go ahead and merge!

@cookiecrook
Copy link
Contributor Author

I hate to push back after you did all this work, and ultimately I defer to you here, but I think make so many tentative files makes it hard to see how the the browsers are doing at a glance: https://wpt.fyi/results/wai-aria/role?label=pr_head&max-count=1&pr=46769

Can't you get the "at a glance" view you want from a higher level directory view like this?
https://wpt.fyi/results/wai-aria

@cookiecrook
Copy link
Contributor Author

but even in the sub level view, the last row indicates the total percentage

@cookiecrook cookiecrook merged commit 39b61c3 into web-platform-tests:master Jun 27, 2024
19 checks passed
@cookiecrook cookiecrook deleted the move-orphaned-role-tests branch June 27, 2024 19:17
@spectranaut
Copy link
Contributor

I hate to push back after you did all this work, and ultimately I defer to you here, but I think make so many tentative files makes it hard to see how the the browsers are doing at a glance: https://wpt.fyi/results/wai-aria/role?label=pr_head&max-count=1&pr=46769

Can't you get the "at a glance" view you want from a higher level directory view like this? https://wpt.fyi/results/wai-aria

I see, you are right!

sadym-chromium pushed a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit moving the "orphaned role" tests to .tentative while ARIA issue discussed
4 participants