-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move orphaned role tests to tentative. #46769
Move orphaned role tests to tentative. #46769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to push back after you did all this work, and ultimately I defer to you here, but I think make so many tentative files makes it hard to see how the the browsers are doing at a glance: https://wpt.fyi/results/wai-aria/role?label=pr_head&max-count=1&pr=46769
For this reason, I think one tentative file per directory might make more sense. It might also be less to maintain, if we want to move things from tentative back into the original test file.
But again, up to you, if you prefer the tests are organized this way -- go ahead and merge!
Can't you get the "at a glance" view you want from a higher level directory view like this? |
but even in the sub level view, the last row indicates the total percentage |
I see, you are right! |
* Move orphaned role tests to tentative. Closes web-platform-tests/interop-accessibility#120
Closes web-platform-tests/interop-accessibility#120