Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Use New JSX Transform on React Native #6

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

kuasha420
Copy link

@kuasha420 kuasha420 commented Nov 25, 2020

Thanks for merging the previous PR. After testing out that PR a bit more I came across some DX issues and tried to fix those in this PR. This PR consists of the following:

  1. Removed React from the scope of all template files (To silence VSCode/TS Unused Variable warnings).
  2. Updated React Native Configs and Babel Config to use new JSX transform (No React is no defined error caused by Step 1).
  3. Added fix for '__DEV__' is not defined #3 __DEV__ is not defined using my proposed solution.
  4. Removed inline styles from template.

This will ensure much better DX for using this package. We can revisit some of this after RN0.64 hits stable. Until then, I think this is all that's can be done.

@RichardLindhout What are your thoughts?

  - React No longer needed in Scope
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants