-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add w3 name get-key
command
#2107
base: main
Are you sure you want to change the base?
Conversation
This better describes what it does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great shout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like half of the solution - how do I then use that key in a different w3 CLI?
Personally I'd call these:
w3 name export <keyId> > priv.key
w3 name import priv.key
@alanshaw having both an |
IMO just one at a time...multiple would mean that there has to be a format to the exported file and I don't want to have to define that, or trust users to pick out a particular key from it. You also can't give it directly to something else that is able to read the keys (like programmatically to the library) without also making changes there. |
...you could also add |
Now refactored as per Alan's suggestion, and tests added for additional fun and profit. |
I think that the failing test here will be fixed by #2151. |
@@ -26,6 +26,7 @@ | |||
"@ipld/car": "^3.1.16", | |||
"conf": "^10.1.1", | |||
"enquirer": "^2.3.6", | |||
"fs": "^0.0.1-security", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"fs": "^0.0.1-security", |
Fixes #1835.