-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the docs about submodules and action ordering. #92
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,20 +26,25 @@ GitHub Actions only have access to the repository they run for. So, in order to | |
This key should start with `-----BEGIN ... PRIVATE KEY-----`, consist of many lines and ends with `-----END ... PRIVATE KEY-----`. | ||
4. In your workflow definition file, add the following step. Preferably this would be rather on top, near the `actions/checkout@v2` line. | ||
|
||
```yaml | ||
# .github/workflows/my-workflow.yml | ||
jobs: | ||
my_job: | ||
... | ||
steps: | ||
- actions/checkout@v2 | ||
# Make sure the @v0.5.3 matches the current version of the | ||
# action | ||
- uses: webfactory/[email protected] | ||
with: | ||
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }} | ||
- ... other steps | ||
``` | ||
```yaml | ||
# .github/workflows/my-workflow.yml | ||
jobs: | ||
my_job: | ||
... | ||
steps: | ||
# This action has to precede ssh-agent, since it undoes its effects | ||
- uses: actions/checkout@v2 | ||
|
||
# Make sure the @v0.5.3 matches the current version of the | ||
# action | ||
- uses: webfactory/[email protected] | ||
with: | ||
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }} | ||
|
||
# Here the ssh keys are available for use | ||
- ... other steps where the repositories are cloned and/or or a submodule update | ||
``` | ||
|
||
5. If, for some reason, you need to change the location of the SSH agent socket, you can use the `ssh-auth-sock` input to provide a path. | ||
|
||
### Using Multiple Keys | ||
|
@@ -49,7 +54,7 @@ There are cases where you might need to use multiple keys. For example, "[deploy | |
You can set up different keys as different secrets and pass them all to the action like so: | ||
|
||
```yaml | ||
# ... contens as before | ||
# ... contents as before | ||
- uses: webfactory/[email protected] | ||
with: | ||
ssh-private-key: | | ||
|
@@ -73,6 +78,22 @@ To support picking the right key in this use case, this action scans _key commen | |
3. For key comments containing such URLs, a Git config setting is written that uses [`url.<base>.insteadof`](https://git-scm.com/docs/git-config#Documentation/git-config.txt-urlltbasegtinsteadOf). It will redirect `git` requests to URLs starting with either `https://github.com/owner/repo` or `[email protected]:owner/repo` to a fake hostname/URL like `[email protected]...:owner/repo`. | ||
4. An SSH configuration section is generated that applies to the fake hostname. It will map the SSH connection back to `github.com`, while at the same time pointing SSH to a file containing the appropriate key's public part. That will make SSH use the right key when connecting to GitHub.com. | ||
|
||
### Support for Submodules | ||
|
||
The submodules are supported, but not directly in the `checkout` action. They have to be cloned *after* the `ssh-agent` step. For example: | ||
|
||
```yaml | ||
- uses: webfactory/[email protected] | ||
with: | ||
ssh-private-key: | | ||
${{ secrets.SSH_SUBMODULE1 }} | ||
${{ secrets.SSH_SUBMODULE2 }} # etc. | ||
- name: Checkout submodules | ||
run: git submodule update --init --recursive | ||
``` | ||
|
||
This works under both Windows and Linux. | ||
|
||
## Exported variables | ||
The action exports the `SSH_AUTH_SOCK` and `SSH_AGENT_PID` environment variables through the Github Actions core module. | ||
The `$SSH_AUTH_SOCK` is used by several applications like git or rsync to connect to the SSH authentication agent. | ||
|
@@ -84,6 +105,12 @@ The `$SSH_AGENT_PID` contains the process id of the agent. This is used to kill | |
|
||
Since each job [runs in a fresh instance](https://help.github.com/en/articles/about-github-actions#job) of the virtual environment, the SSH key will only be available in the job where this action has been referenced. You can, of course, add the action in multiple jobs or even workflows. All instances can use the same `SSH_PRIVATE_KEY` secret. | ||
|
||
### Cannot Precede the `checkout` Action | ||
|
||
The `ssh-agent` step *cannot* precede the `checkout` step, though. The `checkout` action undoes the effects of `ssh-agent`. This will cause errors like: | ||
|
||
ssh: Could not resolve hostname key-<hex-key-id>.github.com: Name or service not known | ||
Comment on lines
+110
to
+112
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Once actions/checkout#833 is merged, that should not happen unless submodules are turned on? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is linked to #148 which is caused by the checkout action setting up a temp HOME directory which breaks the ssh configuration. |
||
|
||
### SSH Private Key Format | ||
|
||
If the private key is not in the `PEM` format, you will see an `Error loading key "(stdin)": invalid format` message. | ||
|
@@ -112,19 +139,19 @@ There are 2 ways you can achieve this: | |
|
||
1. Add this step once in your job **before** any cargo command: | ||
|
||
``` | ||
``` | ||
- name: Update cargo config to use Git CLI | ||
run: Set-Content -Path $env:USERPROFILE\.cargo\config.toml "[net]`ngit-fetch-with-cli = true" | ||
``` | ||
``` | ||
|
||
This will configure Cargo to use the Git CLI as explained in the [Cargo's documentation](https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli). | ||
This will configure Cargo to use the Git CLI as explained in the [Cargo's documentation](https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli). | ||
|
||
2. Alternatively you can set it to the environment variables for the entire workflow: | ||
|
||
``` | ||
env: | ||
CARGO_NET_GIT_FETCH_WITH_CLI: true | ||
``` | ||
``` | ||
env: | ||
CARGO_NET_GIT_FETCH_WITH_CLI: true | ||
``` | ||
|
||
### Using Deploy Keys with Swift Package Manager | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that is fixed in actions/checkout#833, unless submodules are used?