Remove start-up event and revue collab from constants #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viljeno
force-pushed
the
update-interest-form
branch
from
7db87e8 to
9119c7e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3716 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 703 704 +1
Lines 22534 22537 +3
=======================================
+ Hits 20207 20210 +3
Misses 2327 2327 ☔ View full report in Codecov by Sentry. |
|
We probably want to use these fields later, so we probably shouldn't remove this from the backend model. This would actually remove these values from previous interest forms. Code looks good, but I suggest closing this PR since it's not something we should remove. |
ivarnakken
added
the
do-not-merge/hold
|
Just to clarify: updating the frontend was enough! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated interest form as requested by Intercom.
ABA-1232