Allow omission of attributes
if attributeOldValue
or attributeFilter
is present
#12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the whatwg standard,
attributes
has no default value inMutationObserverInit
(i.e., notfalse
).Also,
attributes
should be set totrue
if implicitlytrue
(i.e.,attributeOldValue
orattributeFilter
is specified).This PR will allow the omission of the
attributes
option ifattributeOldValue
orattributeFilter
is specified.Depending on your setup, you can work around this in the meantime by patching the
observe
method:(h/t @chandlerprall)