Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing documents for removal of --define-process-env-node-env #4361

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

junhaoliao
Copy link

What kind of change does this PR introduce?

doc

Did you add tests for your changes?
no

If relevant, did you update the documentation?
yes

Summary

add missing documents for removal of --define-process-env-node-env

Does this PR introduce a breaking change?
no

Other information
fixes #4360

@junhaoliao junhaoliao requested a review from a team as a code owner December 27, 2024 05:54
Copy link

linux-foundation-easycla bot commented Dec 27, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

CHANGELOG.md Outdated
@@ -12,6 +12,7 @@
- removed `init`, `loader` and `plugin` commands in favor [`create-webpack-app`](https://github.com/webpack/webpack-cli/tree/master/packages/create-webpack-app)
- dropped support for `webpack-dev-server@v4`
- minimum supported webpack version is `5.82.0`
- removed `--define-process-env-node-env` in favor of `--config-node-env` option ([#4318](https://github.com/webpack/webpack-cli/pull/4318))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog is auto generated so dont touch that

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes reverted in both CHANGELOG.md and packages/webpack-cli/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of --define-process-env-node-env is undocumented.
3 participants