-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump connect-history-api-fallback from 1.6.0 to 2.0.0 (#2716) #4501
chore: bump connect-history-api-fallback from 1.6.0 to 2.0.0 (#2716) #4501
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add small test case where we send HEAD request when connect-history-api-fallback
is enabled, looks at our tests, it should be easy, thank you for the PR
Codecov Report
@@ Coverage Diff @@
## master #4501 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 16 16
Lines 1600 1600
Branches 604 604
=======================================
Hits 1477 1477
Misses 112 112
Partials 11 11 Continue to review full report at Codecov.
|
You also need to create a snapshot for webpack 4 |
@snitin315 It looks like It's been running for almost 3 hours now. |
For Bugs and Features; did you add new tests?
I have added a new test to test the new behavior
should perform HEAD request in same way as GET
intest/e2e/history-api-fallback.test.js
file.Motivation / Use-Case
Link to issue: #2716
I faced the same problem, I need to solve it =)
Breaking Changes
The
history-api-fallback
now supportsHEAD
requests and handles them the same asGET
.Additional Info