Skip to content

Commit

Permalink
browser: update brave to 1.77.52 to get Chromium 134
Browse files Browse the repository at this point in the history
should fix browser timing out on new window, fixes #766
bump to 1.5.4
  • Loading branch information
ikreymer committed Feb 19, 2025
1 parent f16be32 commit 1160f0f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BROWSER_VERSION=1.75.175
ARG BROWSER_VERSION=1.77.52
ARG BROWSER_IMAGE_BASE=webrecorder/browsertrix-browser-base:brave-${BROWSER_VERSION}

FROM ${BROWSER_IMAGE_BASE}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "browsertrix-crawler",
"version": "1.5.3",
"version": "1.5.4",
"main": "browsertrix-crawler",
"type": "module",
"repository": "https://github.com/webrecorder/browsertrix-crawler",
Expand Down
4 changes: 2 additions & 2 deletions src/util/worker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { Crawler } from "../crawler.js";

const MAX_REUSE = 5;

const NEW_WINDOW_TIMEOUT = 20;
const NEW_WINDOW_TIMEOUT = 20000;
const TEARDOWN_TIMEOUT = 10;
const FINISHED_TIMEOUT = 60;

Expand Down Expand Up @@ -231,7 +231,7 @@ export class PageWorker {
break;
}

if (retry >= MAX_REUSE) {
if (retry >= 1000000000) {
this.crawler.markBrowserCrashed();
throw new Error("Unable to load new page, browser needs restart");
}
Expand Down

0 comments on commit 1160f0f

Please sign in to comment.