WARC 1.1 timestamp precision support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…addresses #37) (reading already possible) - use full millis precision for WARC-Date when using WARC/1.1 - timeutils: iso_date_to_datetime() supports parsing millis param - timeutils: datetime_to_iso_date() supports 'use_millis' param which includes a millis fraction (as prt ISO 8601) - record_http: pass extra args to base warcwriter, supports 'warc_version' param - warc version: can be '1.0' or '1.1', converted to 'WARC/1.0' and 'WARC/1.1' respectively - tests: test warc 1.1 writing directly, through record_http, also add test for utils.open() - warcwriter: curr_warc_date() returns a second precsion (default) to millis precision based on current WARC version
N0taN3rd
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for writing WARC/1.1 records specified via
warc_version=WARC/1.1orwarc_version=1.1When using WARC/1.1, use millisecond precision for
WARC-Datetimeutils: datetime_to_iso_date() includes
use_millisboolean to indicate including the milliseconds.timeutils: iso_date_to_datetime() now also parses the microsecond fraction, if available.
tests: add tests for WARC/1.1, additional test for open()
Update README with WARC 1.1 info
Further addresses #37