-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new notify mechanism and refined selfAddr
semantics, rate limits API and rework sendUpdate docs and drop 'descr'
#94
Open
hpk42
wants to merge
12
commits into
main
Choose a base branch
from
next-main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpk42
changed the title
[WIP] Add new notify mechanism and refined
Add new notify mechanism and refined Dec 3, 2024
selfAddr
semantics, rate limits API and rework sendUpdate docs and drop 'descr'selfAddr
semantics, rate limits API and rework sendUpdate docs and drop 'descr'
introduce message-layer specific limits: sendUpdateMaxSize and sendUpdateInterval
Add API for notifications and refined `selfAddr` and based on discussions with r10s, adb, hocuri, link2xt and others.
… we don't know about xmpp and spaces) -- also reorder notify item to come last in the update property list
* - bring webview restrictions bit from FAQ/hints to the actual spec for messenger - amend UI interaction in chats with "href" handling when clicking info message - some streamlining of language to be more spec like * more streamlining * Update src-docs/spec/messenger.md Co-authored-by: bjoern <[email protected]> --------- Co-authored-by: bjoern <[email protected]>
…tener) some whitespace-streamlining
hpk42
commented
Dec 3, 2024
- `<meta name="viewport" ...>` is useful especially as webviews from different platforms have different defaults | ||
- `<input type="file">` allows importing of files for further | ||
processing; see [`sendToChat()`](../spec/sendToChat.md) for a way to export files | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is moved to spec/messenger.md
because it's a requirement not some hint.
r10s
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.