hamill :: adding the changes I needed in order to make the hillside i… #13
Conversation
There was a problem hiding this comment.
Using a try/except block if undesireable (also the "raise" will cause a traceback) here:
try: self.bios_data.dict['@Redfish.Settings'] except KeyError as ke: log.error(f"Error retrieving settings from remote console. Pending changes in target bios should be applied by a reboot before bios_tool can continue" ) raise
A better way is to use:
if '@Redfish.Settings' not in self.bios_data.dict: log.error(f"Error retrieving settings from server <name the server ip or something>")
So the tool can continue to the next server. Can you make this change?
… tool can continue
…d even though the settings could not be retrieved
|
I changed the try/except to a 'if not in' check as requested :) The logged error message could still use some tuning though - happy to take and suggestions about that |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
also - I think copilot is parsing the word 'credentials' in an f-string even though the variable in the f-string delimiters has nothing to do with credentials in the logs |
|
gimme a hollar on slack if you need me to change anything because the updates/notifications from github are really slow :) |
…efore this change, the GlobalC_stateControl setting was not being considered by the logic
…ismEnable but the closest thing I can find now is PowerProfileSelection
hiya guys - thanks as always for your help while I scrambled to get the bios_tool working for hillside