Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP deployment improvements #278

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

wiktorn
Copy link
Contributor

@wiktorn wiktorn commented Feb 10, 2025

Few minor improvements to the GCP module, if needed, each commit can be split into separate PR:

  • align google-beta provider version with google provider
  • allow providing cloud build service account (depending on the organization settings, it may use default compute engine account as described here, which may not provide necessary permissions to run the build)
  • allow setting of the Cloud Function ingress setting, so customers may easily comply with their organization policies
  • when creating NAT, if there is no default route (which is the case when subnet_autocreate_as_private is `true), which may prevent Internet access and cluster initialization.
  • when there are not project_id / region / zone set at provider level, there were multiple errors. This aligns the deployment to follow provided information
  • add subnet self_links to outputs, so it is easy to reference those when composing this module with other modules
  • allow specifying tags for Cloud Run images, to provide explicit version management

…ings (esp. removal of default route to internet)
…creation as private (which implies no default route)
Ensure correct functionality, when project_id / region / zone is not set
at provider level, or provided value on input differs from provider
default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant