wekadestroy: Add --force to weka local stop
#397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WEKA 4.4, `weka local stop` gracefully stops containers, which is not necessary for the purpose of wekadestroy (predominantly used during deployment for iterative testing or to deploy different configurations). `--force` skips checks for active mounts in older WEKA versions. It adds non-graceful shutdown of containers in 4.4. Given that we unmount file systems on WEKA backends in `wekadestroy`, simply using `--force` globally is acceptable. Additionally, if I recall correctly, clients we forget to unmount should automatically remount file systems on a redeployed (new) cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WEKA 4.4,
weka local stopgracefully stops containers, which is not necessary for the purpose of wekadestroy (predominantly used during deployment for iterative testing or to deploy different configurations).--forceskips checks for active mounts in older WEKA versions. It adds non-graceful shutdown of containers in 4.4.Given that we unmount file systems on WEKA backends in
wekadestroy, simply using--forceglobally is acceptable. Additionally, if I recall correctly, clients we forget to unmount should automatically remount file systems on a redeployed (new) cluster.