Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint python with callable workflow #2790

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/lint_python.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Calls lint_python workflow in https://github.com/wellcomecollection/.github
# using py-actions/flake8@v2 GHA
name: "Python linting"

on: [ push, pull_request ]

jobs:
python_lint:
uses: wellcomecollection/.github/.github/workflows/lint_python.yml@0237abe5edf53b08ebd90f0709537065e28e2d4c
2 changes: 1 addition & 1 deletion ebsco_adapter/ebsco_adapter/src/sync_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def get_marc_file_details(filename):
".xml"
), f"Invalid file type for file {filename}! Skipping..."
assert filename.startswith(
f"ebz-"
"ebz-"
), f"Unexpected file name for file {filename}! Skipping..."

file_date = datetime.datetime.strptime(filename_parts[2], "%Y%m%d")
Expand Down
2 changes: 1 addition & 1 deletion reindexer/scripts/start_reindex.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def start_reindex(ctx, src, dst, mode, input_file):

if src == "all":
warning_message = (
f"Warning: Sending Miro at the same time as everything else "
"Warning: Sending Miro at the same time as everything else "
"may result in the erroneous creation of Image records.\nContinue?"
)
click.confirm(click.style(warning_message, "yellow"), abort=True)
Expand Down
2 changes: 1 addition & 1 deletion scripts/miro_updates.py
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ def update_miro_image_suppressions_doc():

def register_on_dlcs(origin_url, miro_id):
dlcs_response = dlcs_api_client().post(
f"https://api.dlcs.io/customers/2/queue/priority",
"https://api.dlcs.io/customers/2/queue/priority",
json={
"@type": "Collection",
"member": [
Expand Down
Loading