Rds id generator #2818
Open
Rds id generator #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
A refactor that bundles up all the DB Initialisation stuff into one object, driven by config.
How to test
This should (kinda) be a straight refactor. The notable change is that buildDB happens inside workerService.run, rather than Main.
How can we measure success?
This is part of a refactor to facilitate Creating the Lambda version
Have we considered potential risks?
There may have been some reason why buildDB and provisionTable were kept separate, one in Main, the other in run, but I doubt it.