Update ports to use local nginx for dev #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenoir
changed the title
2 tasks
rcantin-w
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Part of wellcomecollection/wellcomecollection.org#11551
This change updates the port that content API uses when run locally in order that it can run at the same time locally to enable a more complete local development experience when working with https://github.com/wellcomecollection/wellcomecollection.org
How to test
./apifolder run:yarn && yarn devThe content API should be available on
localhost:3002.This change can be more thoroughly tested by reviewing wellcomecollection/wellcomecollection.org#11551 and following the relevant steps described running this branch.
How can we measure success?
Easier development!
Have we considered potential risks?
This should have minimal impact as there are no prod changes, and the correct port is flagged to devs when the app starts.