Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /all endpoint documentation #45

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Add /all endpoint documentation #45

merged 6 commits into from
Jan 6, 2025

Conversation

gestchild
Copy link
Contributor

What does this change?

For #43

N.B. The content.yaml is getting a bit unwieldy. I did attempt to break the file up and make bits reusable, but I ran into a bug with swagger where it only seems to recognise the first external file used in a $ref. Rather than waste any more time on it I ended up just editing the content.yaml file, but we may want to revisit this again in the future.

How to test

You can run this locally with yarn start, and look at the new docs

How can we measure success?

It's up to date and useful for anyone we might onboard.

Have we considered potential risks?

N/A

@gestchild gestchild requested review from a team as code owners December 16, 2024 11:49
Copy link
Contributor

@rcantin-w rcantin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-17 at 13 33 38

This is very cool

reference/content.yaml Outdated Show resolved Hide resolved
reference/content.yaml Outdated Show resolved Hide resolved
reference/content.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@rcantin-w rcantin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great, I love how you documented the different types it makes it much easier to understand/play around.

@gestchild gestchild merged commit d7509db into main Jan 6, 2025
2 checks passed
@gestchild gestchild deleted the add-all-endpoint branch January 6, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants