Upgrade to node 20 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnesgaroux
approved these changes
Feb 10, 2025
agnesgaroux
approved these changes
Feb 10, 2025
| @@ -2,6 +2,7 @@ | |||
| set -euo pipefail | |||
|
|
|||
| TERRAFORM_ROLE="arn:aws:iam::760097843905:role/platform-ci" | |||
| export AWS_PAGER="" | |||
There was a problem hiding this comment.
This disables paginating in the AWS CLI. The new version of the docker image is missing less which the AWS CLI uses by default for paging ... however when it is installed the deploy scripts now expect interactivity to dismiss the output of the deploy cli call.
Adding this env var tells the AWS CLI not to care about the presence of a paging tool and not bother trying to use one.
paul-butcher
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Part of wellcomecollection/platform#5916
This change upgrades th lamdba to use Node 20.
How to test
How can we measure success?
Less old node, more new node. Node!
Have we considered potential risks?
If this breaks, it'll stop some subset of dev logs getting to the log server, not very impactful.