Merge pull request #10989 from wellcomecollection/fix-item-requesting…

…-take2 add items as dependency for setItemsState
wellcomecollection · Jul 4, 2024 · d456485 · d456485
2 parents 82a8177 + 566234b
commit d456485
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/content/webapp/components/PhysicalItems/PhysicalItems.tsx b/content/webapp/components/PhysicalItems/PhysicalItems.tsx
@@ -74,7 +74,7 @@ const useItemsState = (
 
   useEffect(() => {
     setItemsState(getItemsState(items, offsiteRequesting));
-  }, []);
+  }, [items]);
 
   return [itemsState, setItemsState];
 };
@@ -92,10 +92,8 @@ const PhysicalItems: FunctionComponent<Props> = ({
     offsiteRequesting
   );
 
-  // This ensures we update an items availability
-  // if the user navigates between items using the archive tree
   useEffect(() => {
-    setItemsState(getItemsState(workItems, offsiteRequesting || false));
+    setPhysicalItems(workItems);
   }, [workItems]);
 
   useAbortSignalEffect(