Codify new geo rate limits #11552
Merged
Codify new geo rate limits #11552
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcantin-w
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This change codifies some new AWS WAF rules that codify new geo rate limits from requests originating in Brazil after seeing significant suspected bot traffic.
The rate limit blocks requests originating from Brazil if they exceed 500 requests per minute.
How to test
This change has been deployed in production for the last week to test impact in traffic.
See WAF results:
See GA active users for the same period:
We see no drop in reported active users although there is significant requests counted as blocked. This indicates sucessful reduction in bot traffic without impacting active users.
How can we measure success?
Reduced load, no outages.
Have we considered potential risks?
As the bot traffic does not advertise itself as such and attempts to use advanced WAF features to match this traffic have failed there is a risk we are degrading the experience for real users in the chosen regions during times of high bot traffic. Identifying that there is no significant impact to active users indicates this is not a widespread problem, mitigating risk.