Fix search links #11553
Open
Fix search links #11553
+267
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.1 kB (+0.11%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
| doc: { | ||
| type: 'Exhibition highlight tour', | ||
| uid: '1', | ||
| highlightTourType: 'text' as HighlightTourType, |
There was a problem hiding this comment.
is this a thing? I think highlightTourType can only be one of bsl or audio because those share the same data. Exhibition text is its own type I think?
There was a problem hiding this comment.
It's for handling the legacy exhibition-guides type
| isContentType, | ||
| } from './content-types'; | ||
|
|
||
| export type HighlightTourType = 'audio' | 'bsl' | 'text'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Work we did on the all search, to make the results links work, broke some other links on the site and had to be reverted
This reimplements those changes, without breaking the other links.
How to test
How can we measure success?
All the site links and search links work
Have we considered potential risks?
The link-resolver.test now covers everything so we should be good, unless I've missed places we are creating links without the linkResolver function