Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webdriver cache mode #1756

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

jgraham
Copy link
Member

@jgraham jgraham commented May 29, 2024

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (not for CORS changes): …
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

jgraham added 2 commits July 3, 2024 10:28
The primary use case here is allowing WebDriver to enforce that requests do not
use the network cache, including the CORS preflight cache. But for
future extension the this works by calling into WebDriver BiDi to get
a cache behavior for the request, which is then translated into
specific implementation on the fetch side (e.g. setting the request's
cache mode, or not using the preflight cache).

For now the only possible values of the cache behavior are "default"
and "bypass", so we only need to check for the latter value.
@jgraham jgraham force-pushed the webdriver_cache_mode branch from 206f279 to 48fc0f9 Compare July 3, 2024 09:28
@@ -2156,6 +2156,11 @@ Unless stated otherwise, it is false.

<p class=note>This is for exclusive use by HTML's navigate algorithm. [[!HTML]]

<p>A <a for=/>request</a> has an associated <dfn export for=request>WebDriver navigation id</dfn>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the base branch for this PR https://github.com/whatwg/fetch/pull/1540/files ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@whimboo
Copy link

whimboo commented Jul 3, 2024

@jgraham would you mind updating this PR to the latest state of the WebDriver BiDi PR which we basically will merge? Thanks.

@whimboo
Copy link

whimboo commented Jul 17, 2024

The WebDriver BiDi spec was updated around 2 weeks ago. @jgraham, we probably should get this PR landed as well anytime soon to finish that particular feature. Thanks.

@jgraham
Copy link
Member Author

jgraham commented Jul 17, 2024

This is mostly blocked on landing #1540

I'm not aware of any further changes that are needed in the commit added in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants