feature: add embedded 4four.io metronome above video component #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add: metronome iframe wrapper and show/hide btn - added styles and an iframe relating to a metronome show hide button and iframe wrapper
|
Thank you! I will have a think about this and get back to you! As per my previous comment in the other PR, I'm having trouble getting this to run locally so I would love to know how you did it 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've been using Fretonator a lot lately and was pleased to see that it was an Angular app! I'd like to bring this simple, hidden metronome embed up for consideration as an add-on to the existing site. I loved the simple look of the
Learn about the 7 patternsbutton and thought using it might be a nice way to break the sections up. I know the light theme of the metronome embed can be a bit abrasive on the dark theme, but open to suggestions!Learn about the 7 patternsbutton.Screenshots: