Add scalar types #21
Open
Add scalar types #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we do not have to check for `false` later on
…rayElementTrimUnescape` These functions mostly do the same thing, but with different implementations. Merge the `arrayTrimUnescape` and `arrayTrimSliceUnescape` functions together, and make `arrayElementTrimUnescape` use the previous one, so if we want to change how lists are evaluated, the algorithm is in a single place
so we do not have sometimes strings, and other times PPNodes, so we can type any pattern variable as a string.
Sometimes written as int, while it always is passed as a string Also forgot to push pattern fixes in SimpleFunctions.php in previous commit
with MediaWiki 1.43
1.43 requires PHP 8.0, so I assume we can safely use union types now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object types have been previously added in #10 for consistency with core extensions, this PR adds types for all function arguments and returned values, as much as possible.
To simplify some function signatures, some functions are slightly changed to only accept
string, instead ofstring|PPNodeorstring|null.Also, use optional arguments to merge
arrayTrimSliceUnescapewitharrayTrimUnescape: both functions do the same thing but with different implementations.