Prevent showing survey twice.

wikimedia · Nov 22, 2024 · cd92e84 · cd92e84
1 parent 4ab693d
commit cd92e84
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.kt b/app/src/main/java/org/wikipedia/page/PageActivity.kt
@@ -910,7 +910,7 @@ class PageActivity : BaseActivity(), PageFragment.Callback, LinkPreviewDialog.Lo
         }) {
             delay(TimeUnit.SECONDS.toMillis(if (ReleaseUtil.isDevRelease) 1L else 10L))
             pageFragment.historyEntry?.let {
-                if (it.source == HistoryEntry.SOURCE_RABBIT_HOLE_SEARCH) {
+                if (!Prefs.suggestedContentSurveyShown && it.source == HistoryEntry.SOURCE_RABBIT_HOLE_SEARCH) {
                     Prefs.suggestedContentSurveyShown = true
                     SurveyDialog.showFeedbackOptionsDialog(
                         this@PageActivity,

diff --git a/app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.kt b/app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.kt
@@ -858,14 +858,16 @@ class ReadingListsFragment : Fragment(), SortReadingListsDialog.Callback, Readin
             L.e(t)
         }) {
             delay(TimeUnit.SECONDS.toMillis(if (ReleaseUtil.isDevRelease) 1L else 10L))
-            Prefs.suggestedContentSurveyShown = true
-            SurveyDialog.showFeedbackOptionsDialog(
-                requireActivity(),
-                titleId = R.string.rabbit_holes_survey_dialog_title,
-                messageId = R.string.rabbit_holes_survey_dialog_body,
-                snackbarMessageId = R.string.survey_dialog_submitted_snackbar,
-                invokeSource = InvokeSource.RABBIT_HOLE_READING_LIST
-            )
+            if (!Prefs.suggestedContentSurveyShown) {
+                Prefs.suggestedContentSurveyShown = true
+                SurveyDialog.showFeedbackOptionsDialog(
+                    requireActivity(),
+                    titleId = R.string.rabbit_holes_survey_dialog_title,
+                    messageId = R.string.rabbit_holes_survey_dialog_body,
+                    snackbarMessageId = R.string.survey_dialog_submitted_snackbar,
+                    invokeSource = InvokeSource.RABBIT_HOLE_READING_LIST
+                )
+            }
         }
     }