Patroller Tasks (feature branch) #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/org/wikipedia/diff/ArticleEditDetailsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/wikipedia/diff/ArticleEditDetailsFragment.kt
Outdated
Show resolved
Hide resolved
…4239) * Patroller Tasks: update TalkReply activity to handle saved templates * Connect talk replay activity with diff screen * Add checkbox and radio * Add radio and checkbox logic * Add percentage suffix for damage and intent * Adding mutiple livedata * Add the logic of handling template dialog * Update message * Update warn button listener * Add spinner to reply interface * Add onclick event * integrate with dialog * Solify logic of managing dialogs * Remove comment * Optimize stuff * Update logic of managing template * Remove testing button * Minor design update * Minor layout visibility update * lint * Make the dialog scrollable * Replace radios to checkbox and optimze logic * design comment * Update input text error stauts * Update the error text
|
|
I cannot reproduce it on both of my devices but I can guess why it has the issue. I have updated the end margin, please see the change, thanks! |
…dit (#4247) * Fix: only inflate menu once in the ArticleeditDetailsFramgent * Change .add to .replace to avoid adding multiple fragment * Only commit fragment if there has no instance
* Adding Indonesian translations for Patroller tasks feature * Complete translations --------- Co-authored-by: Sharvani Haran <[email protected]>
* Fix: Patroller Tasks user experience update * Wording
* Data wiring: Patroller tasks * Final wiring * Fix: Multiple streams usage (#4248) Co-authored-by: Sharvani Haran <[email protected]> * More event updates * Improvements to logging logic * Simplify wikiId by using preferences * Detect source for data events * CR comments addressed * Minor change * Lint fix and minor update * Minor change * Swipe event added --------- Co-authored-by: Sharvani Haran <[email protected]>
* Data wiring: Patroller tasks * Final wiring * Fix: Multiple streams usage (#4248) Co-authored-by: Sharvani Haran <[email protected]> * More event updates * Improvements to logging logic * Simplify wikiId by using preferences * Detect source for data events * CR comments addressed * Minor change * Lint fix and minor update * Minor change * Swipe event added * Add data wiring to filter selection * Minor change --------- Co-authored-by: Sharvani Haran <[email protected]>
Co-authored-by: Sharvani Haran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can serve as the branch where Patroller Tasks functionality will be merged, until it's ready to go.
https://phabricator.wikimedia.org/T343224