-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify available languages retrieval #4406
Open
Isira-Seneviratne
wants to merge
11
commits into
wikimedia:main
Choose a base branch
from
Isira-Seneviratne:LanguageUtil_improve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Simplify available languages retrieval #4406
Isira-Seneviratne
wants to merge
11
commits into
wikimedia:main
from
Isira-Seneviratne:LanguageUtil_improve
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
requested review from
cooltey,
dbrant and
sharvaniharan
as code owners
January 19, 2024 22:26
# Conflicts: # app/src/main/java/org/wikipedia/language/LanguageUtil.kt # app/src/test/java/org/wikipedia/language/LanguageUtilTest.java
Isira-Seneviratne
force-pushed
the
LanguageUtil_improve
branch
from
May 19, 2024 09:13
3d08203
to
d7e66a6
Compare
Please resolve the conflicts. Thanks! |
# Conflicts: # app/src/main/java/org/wikipedia/language/LanguageUtil.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the available languages retrieval method using sequence operations