-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rabbit Holes (feature branch) #5114
Conversation
…id-wikipedia into rabbit_holes_design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick review and will do another round of review today (before you off from work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found issues:
- When on the suggested reading list screen, it is possible to swipe to refresh. Should we disable it?
- The "experiment" card overlapped when on the search mode in the reading list. (happens when no results found in the list)
- When trying to Save the recommended list, the articles that don't have images will still show the placeholder. Do we want to hide it instead?
- For analytics, I am not able to monitor the
app_rabbit_holes
from https://stream-beta.wmflabs.org/v2/ui/#/ is this expected?
app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/wikipedia/search/RecentSearchesFragment.kt
Outdated
Show resolved
Hide resolved
Sure!
Done. (The suggested reading list will be hidden from searching)
This does not appear to be an issue introduced in this PR.
This stream/schema has not yet been deployed. (This is not going to production yet.) |
Implementation of the Rabbit Holes experiment.
Phabricator:
https://phabricator.wikimedia.org/T379379
https://phabricator.wikimedia.org/T379381
https://phabricator.wikimedia.org/T379382