Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rabbit Holes (feature branch) #5114

Merged
merged 28 commits into from
Nov 22, 2024
Merged

Rabbit Holes (feature branch) #5114

merged 28 commits into from
Nov 22, 2024

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Nov 12, 2024

@dbrant dbrant added WIP Work in progress Design review labels Nov 12, 2024
@dbrant dbrant removed the WIP Work in progress label Nov 20, 2024
Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick review and will do another round of review today (before you off from work)

Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found issues:

  • When on the suggested reading list screen, it is possible to swipe to refresh. Should we disable it?
  • The "experiment" card overlapped when on the search mode in the reading list. (happens when no results found in the list)
  • When trying to Save the recommended list, the articles that don't have images will still show the placeholder. Do we want to hide it instead?
  • For analytics, I am not able to monitor the app_rabbit_holes from https://stream-beta.wmflabs.org/v2/ui/#/ is this expected?

@dbrant
Copy link
Member Author

dbrant commented Nov 22, 2024

@cooltey

  • When on the suggested reading list screen, it is possible to swipe to refresh. Should we disable it?

Sure!

  • The "experiment" card overlapped when on the search mode in the reading list. (happens when no results found in the list)

Done. (The suggested reading list will be hidden from searching)

  • When trying to Save the recommended list, the articles that don't have images will still show the placeholder. Do we want to hide it instead?

This does not appear to be an issue introduced in this PR.

This stream/schema has not yet been deployed. (This is not going to production yet.)

@cooltey cooltey merged commit 3bd22e6 into main Nov 22, 2024
2 checks passed
@cooltey cooltey deleted the rabbit_holes_design branch November 22, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants