-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Year-in-review Feed card. #5179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good but when i turn on the Year-in-review Feed card from the settings preference I don't see it appear on the explore feed. The shouldShow function is returning true in the YIROnboardingCard.
@Williamrai Ah yes, this is a little tricky. If you dismiss this card, here is how to show it again:
|
@@ -88,4 +88,7 @@ | |||
<string name="diff_link_wikitext">{{{diffLink}}}</string> | |||
<string name="wikiText_replace_url">[[%1$s|%2$s]]</string> | |||
|
|||
<string name="year_in_review_action_positive">Take me there</string> | |||
<string name="year_in_review_text"><![CDATA[<strong>Wikipedia 2024 Year in Review</strong><br/><br/>Wikipedia is the largest knowledge resource ever assembled in the history of the world, and it’s freely available to everyone everywhere. Here’s a review of 2024 through the lens of Wikipedia.]]></string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I made these strings non-translatable on purpose, since this feature will be available for English only, therefore translators don't need to be bothered.)
https://phabricator.wikimedia.org/T381802