Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year-in-review Feed card. #5179

Merged
merged 16 commits into from
Jan 16, 2025
Merged

Year-in-review Feed card. #5179

merged 16 commits into from
Jan 16, 2025

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Dec 13, 2024

@dbrant dbrant added WIP Work in progress Design review labels Dec 13, 2024
@dbrant dbrant removed WIP Work in progress Design review labels Jan 15, 2025
Copy link
Collaborator

@Williamrai Williamrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but when i turn on the Year-in-review Feed card from the settings preference I don't see it appear on the explore feed. The shouldShow function is returning true in the YIROnboardingCard.

@dbrant
Copy link
Member Author

dbrant commented Jan 16, 2025

Everything looks good but when i turn on the Year-in-review Feed card from the settings preference I don't see it appear on the explore feed. The shouldShow function is returning true in the YIROnboardingCard.

@Williamrai Ah yes, this is a little tricky. If you dismiss this card, here is how to show it again:

  • In Developer settings, turn on "Year-in-review Feed Card"
  • Also in Developer settings, find the setting called "feedHiddenCards" (near the middle of the list) and blank it out.
  • Exit the app entirely, then relaunch it to get back to the Feed, and you should see the card.

@@ -88,4 +88,7 @@
<string name="diff_link_wikitext">{{{diffLink}}}</string>
<string name="wikiText_replace_url">[[%1$s|%2$s]]</string>

<string name="year_in_review_action_positive">Take me there</string>
<string name="year_in_review_text"><![CDATA[<strong>Wikipedia 2024 Year in Review</strong><br/><br/>Wikipedia is the largest knowledge resource ever assembled in the history of the world, and it’s freely available to everyone everywhere. Here’s a review of 2024 through the lens of Wikipedia.]]></string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I made these strings non-translatable on purpose, since this feature will be available for English only, therefore translators don't need to be bothered.)

@cooltey cooltey merged commit 5f31853 into main Jan 16, 2025
2 checks passed
@cooltey cooltey deleted the yirCard_design branch January 16, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants