Apply fixes from StyleCI

wilburpowery · Jan 9, 2018 · 88f0788 · 88f0788
1 parent c2b3653
commit 88f0788
Show file tree

Hide file tree

Showing 63 changed files with 323 additions and 312 deletions.
diff --git a/app/Business.php b/app/Business.php
@@ -10,7 +10,7 @@ class Business extends Model
     protected $guarded = [];
 
     /**
-     * Users relationship
+     * Users relationship.
      */
     public function users(): HasMany
     {
@@ -23,15 +23,15 @@ public function clients()
     }
 
     /**
-     * Daily Budgets relationship
+     * Daily Budgets relationship.
      */
     public function dailyBudgets()
     {
         return $this->hasMany(DailyBudget::class);
     }
 
     /**
-     * Transactions relationship
+     * Transactions relationship.
      */
     public function transactions()
     {
@@ -41,9 +41,9 @@ public function transactions()
     public function addClient($data)
     {
         return $this->clients()->create([
-            'name' => $data['name'],
-            'email' => $data['email'],
-            'phone_number' => $data['phone_number']
+            'name'         => $data['name'],
+            'email'        => $data['email'],
+            'phone_number' => $data['phone_number'],
         ]);
     }
 }
diff --git a/app/Console/Kernel.php b/app/Console/Kernel.php
@@ -19,7 +19,8 @@ class Kernel extends ConsoleKernel
     /**
      * Define the application's command schedule.
      *
-     * @param  \Illuminate\Console\Scheduling\Schedule  $schedule
+     * @param \Illuminate\Console\Scheduling\Schedule $schedule
+     *
      * @return void
      */
     protected function schedule(Schedule $schedule)

diff --git a/app/DailyBudget.php b/app/DailyBudget.php
@@ -2,8 +2,8 @@
 
 namespace App;
 
-use Illuminate\Database\Eloquent\Model;
 use Carbon\Carbon;
+use Illuminate\Database\Eloquent\Model;
 
 class DailyBudget extends Model
 {
@@ -18,6 +18,7 @@ public static function fromToday()
      * Convert to cents before saving.
      *
      * @param string $value
+     *
      * @return void
      */
     public function setTotalAttribute($value)
@@ -27,7 +28,6 @@ public function setTotalAttribute($value)
 
     /**
      * Convert the total back to decimal value.
-     *
      */
     public function getTotalAttribute()
     {

diff --git a/app/Desk.php b/app/Desk.php
@@ -2,8 +2,8 @@
 
 namespace App;
 
-use Illuminate\Database\Eloquent\Model;
 use Carbon\Carbon;
+use Illuminate\Database\Eloquent\Model;
 
 class Desk extends Model
 {

diff --git a/app/Exceptions/Handler.php b/app/Exceptions/Handler.php
@@ -31,7 +31,8 @@ class Handler extends ExceptionHandler
      *
      * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
      *
-     * @param  \Exception  $exception
+     * @param \Exception $exception
+     *
      * @return void
      */
     public function report(Exception $exception)
@@ -42,8 +43,9 @@ public function report(Exception $exception)
     /**
      * Render an exception into an HTTP response.
      *
-     * @param  \Illuminate\Http\Request  $request
-     * @param  \Exception  $exception
+     * @param \Illuminate\Http\Request $request
+     * @param \Exception               $exception
+     *
      * @return \Illuminate\Http\Response
      */
     public function render($request, Exception $exception)

diff --git a/app/Http/Controllers/AccountingDataController.php b/app/Http/Controllers/AccountingDataController.php
@@ -2,9 +2,9 @@
 
 namespace App\Http\Controllers;
 
-use App\Transaction;
 use App\DailyBudget;
 use App\Desk;
+use App\Transaction;
 
 class AccountingDataController extends Controller
 {
@@ -24,9 +24,9 @@ public function __invoke()
 
         return response([
             'alreadyHasClosedDesk' => Desk::hasAlreadyBeenClosed(),
-            'dailyBudget' => $dailyBudget,
-            'income' => $incomes,
-            'expense' => $expenses
+            'dailyBudget'          => $dailyBudget,
+            'income'               => $incomes,
+            'expense'              => $expenses,
         ]);
     }
 }
diff --git a/app/Http/Controllers/Auth/RegisterController.php b/app/Http/Controllers/Auth/RegisterController.php
@@ -2,10 +2,10 @@
 
 namespace App\Http\Controllers\Auth;
 
-use App\User;
 use App\Http\Controllers\Controller;
-use Illuminate\Support\Facades\Validator;
+use App\User;
 use Illuminate\Foundation\Auth\RegistersUsers;
+use Illuminate\Support\Facades\Validator;
 
 class RegisterController extends Controller
 {
@@ -42,33 +42,35 @@ public function __construct()
     /**
      * Get a validator for an incoming registration request.
      *
-     * @param  array  $data
+     * @param array $data
+     *
      * @return \Illuminate\Contracts\Validation\Validator
      */
     protected function validator(array $data)
     {
         return Validator::make($data, [
-            'name' => 'required|string|max:255',
-            'email' => 'required|string|email|max:255|unique:users',
-            'password' => 'required|string|min:6|confirmed',
-            'business_id' => 'required|numeric'
+            'name'        => 'required|string|max:255',
+            'email'       => 'required|string|email|max:255|unique:users',
+            'password'    => 'required|string|min:6|confirmed',
+            'business_id' => 'required|numeric',
         ]);
     }
 
     /**
      * Create a new user instance after a valid registration.
      *
-     * @param  array  $data
+     * @param array $data
+     *
      * @return \App\User
      */
     protected function create(array $data)
     {
         return User::create([
-            'name' => $data['name'],
-            'email' => $data['email'],
-            'password' => bcrypt($data['password']),
+            'name'        => $data['name'],
+            'email'       => $data['email'],
+            'password'    => bcrypt($data['password']),
             'business_id' => $data['business_id'],
-            'is_admin' => true,
+            'is_admin'    => true,
         ]);
     }
 }
diff --git a/app/Http/Controllers/BusinessesController.php b/app/Http/Controllers/BusinessesController.php
@@ -9,8 +9,8 @@ class BusinessesController extends Controller
     public function store()
     {
         $data = request()->validate([
-            'name' => 'required',
-            'description' => 'required'
+            'name'        => 'required',
+            'description' => 'required',
         ]);
 
         $business = Business::create($data);

diff --git a/app/Http/Controllers/ClientsController.php b/app/Http/Controllers/ClientsController.php
@@ -2,16 +2,17 @@
 
 namespace App\Http\Controllers;
 
+use App\Client;
 use Illuminate\Http\Request;
 use Illuminate\Validation\Rule;
-use App\Client;
 
 class ClientsController extends Controller
 {
     public function index()
     {
         if ($search = request('q')) {
             $client = Client::where('name', 'like', "%$search%")->get();
+
             return $client;
         }
 
@@ -23,15 +24,15 @@ public function index()
     public function store()
     {
         $data = request()->validate([
-            'name' => 'required|string|min:1',
+            'name'  => 'required|string|min:1',
             'email' => [
                 'required',
                 'email',
                 Rule::unique('clients')->where(function ($query) {
                     return $query->where('business_id', auth()->user()->business->id);
-                })
+                }),
             ],
-            'phone_number' => 'required'
+            'phone_number' => 'required',
         ]);
 
         $client = auth()->user()->business->addClient($data);
@@ -51,15 +52,15 @@ public function update(Client $client)
         $this->authorize('update', $client);
 
         $data = request()->validate([
-            'name' => 'required|string|min:1',
+            'name'  => 'required|string|min:1',
             'email' => [
                 'required',
                 'email',
                 Rule::unique('clients')->ignore($client->id)->where(function ($query) {
                     return $query->where('business_id', auth()->user()->business->id);
-                })
+                }),
             ],
-            'phone_number' => 'required'
+            'phone_number' => 'required',
         ]);
 
         $client->update($data);

diff --git a/app/Http/Controllers/Controller.php b/app/Http/Controllers/Controller.php
@@ -2,10 +2,10 @@
 
 namespace App\Http\Controllers;
 
+use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
 use Illuminate\Foundation\Bus\DispatchesJobs;
-use Illuminate\Routing\Controller as BaseController;
 use Illuminate\Foundation\Validation\ValidatesRequests;
-use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
+use Illuminate\Routing\Controller as BaseController;
 
 class Controller extends BaseController
 {

diff --git a/app/Http/Controllers/DailyBudgetsController.php b/app/Http/Controllers/DailyBudgetsController.php
@@ -2,8 +2,8 @@
 
 namespace App\Http\Controllers;
 
-use Illuminate\Http\Request;
 use App\DailyBudget;
+use Illuminate\Http\Request;
 
 class DailyBudgetsController extends Controller
 {
@@ -17,12 +17,12 @@ public function index()
     public function store()
     {
         $data = request()->validate([
-            'daily_budget' => 'required|numeric'
+            'daily_budget' => 'required|numeric',
         ]);
 
         $budget = DailyBudget::create([
             'business_id' => auth()->user()->business->id,
-            'total' => $data['daily_budget']
+            'total'       => $data['daily_budget'],
         ]);
 
         return $budget;

diff --git a/app/Http/Controllers/DashboardController.php b/app/Http/Controllers/DashboardController.php
@@ -22,8 +22,8 @@ public function index()
 
         return response([
             'dailyBudget' => $dailyBudget,
-            'income' => $incomes,
-            'expense' => $expenses
+            'income'      => $incomes,
+            'expense'     => $expenses,
         ]);
     }
 

diff --git a/app/Http/Controllers/DeskClosesController.php b/app/Http/Controllers/DeskClosesController.php
@@ -7,19 +7,19 @@ class DeskClosesController extends Controller
     public function store()
     {
         $data = request()->validate([
-            'initial_balance' => 'required|numeric',
-            'income' => 'required|numeric',
-            'expense' => 'required|numeric',
-            'transfers' => 'required|numeric',
-            'card_payments' => 'required|numeric',
-            'earn_sp' => 'required|numeric',
-            'deposit_sp' => 'required|numeric',
-            'commission_sp' => 'required|numeric',
-            'refills' => 'required|numeric',
+            'initial_balance'    => 'required|numeric',
+            'income'             => 'required|numeric',
+            'expense'            => 'required|numeric',
+            'transfers'          => 'required|numeric',
+            'card_payments'      => 'required|numeric',
+            'earn_sp'            => 'required|numeric',
+            'deposit_sp'         => 'required|numeric',
+            'commission_sp'      => 'required|numeric',
+            'refills'            => 'required|numeric',
             'commission_refills' => 'required|numeric',
-            'cash_box' => 'required|numeric',
-            'final_balance' => 'required|numeric',
-            'real_balance' => 'required|numeric'
+            'cash_box'           => 'required|numeric',
+            'final_balance'      => 'required|numeric',
+            'real_balance'       => 'required|numeric',
             ]);
 
         auth()->user()->closeDesk($data);

diff --git a/app/Http/Controllers/ExpensesController.php b/app/Http/Controllers/ExpensesController.php
@@ -2,8 +2,8 @@
 
 namespace App\Http\Controllers;
 
-use Illuminate\Http\Request;
 use App\Transaction;
+use Illuminate\Http\Request;
 
 class ExpensesController extends Controller
 {
@@ -19,16 +19,16 @@ public function index()
     public function store()
     {
         $data = request()->validate([
-            'type' => 'required',
+            'type'        => 'required',
             'description' => 'required',
-            'total' => 'required|numeric'
+            'total'       => 'required|numeric',
             ]);
 
         auth()->user()->business->transactions()->create([
-                'type' => $data['type'],
-                'description' => $data['description'],
-                'total' => $data['total'],
-                'transaction_type' => 'App\Expense'
+                'type'             => $data['type'],
+                'description'      => $data['description'],
+                'total'            => $data['total'],
+                'transaction_type' => 'App\Expense',
                 ]);
     }
 
@@ -42,9 +42,9 @@ public function show(Transaction $expense)
     public function update(Transaction $expense)
     {
         $data = request()->validate([
-                    'type' => 'required',
+                    'type'        => 'required',
                     'description' => 'required',
-                    'total' => 'required'
+                    'total'       => 'required',
                     ]);
 
         $this->authorize('update', $expense);

diff --git a/app/Http/Controllers/GraphsController.php b/app/Http/Controllers/GraphsController.php
@@ -14,7 +14,7 @@ public function income()
 
         return [
             'Ingresos' => $income,
-            'Egresos' => $expense
+            'Egresos'  => $expense,
         ];
     }
 }