[DO NOT MERGE] refactor: avoid duplicate tweet by re-structure and modularize the reminder options #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(job): store each match with 2 different reminder_times * refactor(match-fetcher): add reminder_time in redis fixtures and double up the match stored * fix: format * temp: add branch to target against for CI test
* chore: add hours_to_match inside redis * fix: npm format
…105) * refactor(match-reader): fetch latest redis match and immediately remove it from data once published * refactor(match-reader): use match time and update test * run npm format * fix: better error handling
* chore: update prettier format * update package.json * update serp API get implementation in http get test * chore: add optional query of club and location when fetching serp API * refactor(job): fetch using env variables and add guard for converting date string to date * test: adjust test for error handling * refactor: change date calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #62 and #54
Checklist
Screenshot of the test