Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a set of functions that fetch and store the FMS alliance #33

Closed
wants to merge 2 commits into from

Conversation

fruzyna
Copy link
Member

@fruzyna fruzyna commented Mar 10, 2024

Subsystem: Framework Core

Description:

Created 3 functions in Core. First a function that will return a stored Alliance. If nothing is stored it will be fetched from the FMS and stored. Then two helper functions which wrap the first and return a boolean comparing it to red/blue.

Tested: No

@fruzyna fruzyna added the enhancement New feature or request label Mar 10, 2024
@fruzyna fruzyna requested review from Zaque2 and smccrorie March 10, 2024 15:23
Copy link

@Zaque2 Zaque2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure your thoughts, would it be worth it to add a Log.warn() to these functions if the alliance is undefined?

@fruzyna
Copy link
Member Author

fruzyna commented Mar 10, 2024

Not sure your thoughts, would it be worth it to add a Log.warn() to these functions if the alliance is undefined?

Good idea

@fruzyna fruzyna closed this Jan 2, 2025
@fruzyna fruzyna deleted the store_fms_alliance branch January 2, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants