Pull KWin patches (2024-01-10 - 2024-05-23) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entry' Not all task switchers use icons, so "entry" is more fitting.
They were lost during KDecoration 1 -> KDecoration 2 transition. CCBUG: 348393 CCBUG: 438719
m_bridge->createDecoration() can return nullptr. Most codepaths already guard against that, but not all of them BUG: 456531
It's been added there after starting life in kcmutils. Depends on https://invent.kde.org/frameworks/kirigami/-/merge_requests/1488.
This makes the types visible to QML tooling
By design, these categories of content can run arbitrary code on the system. This makes them security-sensitive and risky, so we need to inform the user about it. Depends on https://invent.kde.org/frameworks/knewstuff/-/merge_requests/309
I swapped the order of "Add" and row count because (in LTR layouts) row captions are on the left and an "Add" button on the right sits right on top of the "Remove" buttons in the list view.
Now that we have Kirigami.Units.cornerRadius, there's a central source of truth for corner radius so don't have to use random numbers for these anymore. Part of https://invent.kde.org/teams/vdg/issues/-/issues/45.
Also pull "Rows" out of the SpinBox into a dedicated label. Both to address concerns "Add" about being misinterpreted as "Add Row", given that the button to add a new virtual desktop now sits right next to the row count spinner.
The extraFooterTopPadding property used to do this is now somewhat incoherent, but we're stuck with it until KF7.
This avoids unexpectedly exiting the whole KCM when just trying to cancel the Export mode (based on a true story)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to listings in winft/como#24.