fix mqtt topic and device name collision #59
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xrEngine512
commented
Apr 25, 2018
•
xrEngine512
commented
- При использовании MQTT id из шаблона помимо slave_id добавляет индекс порта
- При нахождении устройств с одинаковыми именами добавляет номер устройству и/или информацию о порте, на котором оно расположено в зависимости от того на одном порту расположены устройства или нет.
|
Поведение нужно описать в README и в описании pull-request-а |
если это правда, то это дичайше ломает обратную совместимость. У всех клиентов при обновлении пакета всё сломается нафиг. Естественно править топики и имена нужно только при обнаружении коллизии |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.