Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create Docusaurus documentation site for Copilot by Detox #29

Merged
merged 7 commits into from
Jan 3, 2025

Conversation

LironMShemen
Copy link
Collaborator

This commit adds a new Docusaurus-based documentation site with:

Guides Section:

  • Integrating with Testing Frameworks: Overview of Copilot's capabilities.
  • Technical Overview: Adapted from Detox docs (to be removed there).
  • Best Practices: Framework-agnostic step-by-step guidance.
  • Custom Driver Implementation: Guide to creating and adding testing framework drivers.
  • Contributing: Details on adding prompt handlers and drivers, with tips and github link.

API Section:

  • Interface Overview: Lifecycle commands (init, start, perform, end).
  • Prompt Handlers: Writing and contributing (src/prompt-handlers).
  • Framework Drivers: Custom implementation, snapshot support, and type references.

Showcase Page:

  • Highlights Detox as the initial use case and invites collaboration with other frameworks.

@d4vidi d4vidi linked an issue Nov 26, 2024 that may be closed by this pull request
4 tasks
Copy link

@noomorph noomorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start from removing some redundancy, ok?

website/src/pages/markdown-page.md Outdated Show resolved Hide resolved
website/README.md Outdated Show resolved Hide resolved
favicon: '/img/homepage/detox-logo.png',

// Set the production url of your site here
url: 'https://your-docusaurus-site.example.com',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is better to be updated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does 'https://copilotbydetox.com/' sound?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you deploy it to, currently?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know actually. Can I just choose to deploy to this address?

Copy link
Collaborator

@asafkorem asafkorem Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LironMShemen no, to deploy to a domain we need to buy it.. Someday maybe

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with a plain deployment to github pages

website/docusaurus.config.js Outdated Show resolved Hide resolved
website/docusaurus.config.js Outdated Show resolved Hide resolved
website/docusaurus.config.js Outdated Show resolved Hide resolved
website/docusaurus.config.js Outdated Show resolved Hide resolved
website/docusaurus.config.js Outdated Show resolved Hide resolved
website/package.json Outdated Show resolved Hide resolved
website/src/css/_showcase-link.scss Show resolved Hide resolved
Copy link

@noomorph noomorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please fix your .nvmrc to use lts/jod (Node 22), instead of that embarrasing thing inside: 😅 I mean, just like a grenade that did not explode, there's this snippet of Shell script there inside:

echo "20" > .nvmrc

Overall, good job, but a few places still need some polish.

website/src/pages/index.module.scss Outdated Show resolved Hide resolved
<img
src="/img/homepage/copilot-demo.gif"
alt="Demo Gif"
className={styles.bottomRightGif}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not convinced that GIF is the best solution in this case.

  1. It does not compress well; consider using WebP or other more modern formats instead.
  2. To enhance user experience, a video file (WebM or whatever) would be ideal. This allows viewers to open it in fullscreen mode, pause/resume, etc. making it more usable, especially on mobile devices.

website/src/pages/index.js Outdated Show resolved Hide resolved
website/src/pages/index.js Outdated Show resolved Hide resolved
website/src/pages/index.js Outdated Show resolved Hide resolved
website/src/css/_showcase-link.scss Show resolved Hide resolved
@noomorph
Copy link

And also, please check the narrow viewport (360px+). I don't think your layout looks clean enough there (uneven distances between elements, and abruptly ending bottom padding, at the very least, is what I can notice).

Here's my suggestion (actual vs what-i-would-have-expected-maybe), maybe it will help:

localhost_3000_detox-copilot_ (1) localhost_3000_detox-copilot_

↑ The positioning of the image (whether it has to be 2nd, or 3rd, or 4th) — is not something I am firmly decided on, but still... I tend to believe that it's best to put it either 2nd or 3rd element in this vertical stack. I think, being the last element doesn't make it a good advertising job, especially if it gets cropped on 640px height viewport devices.

…tial commit

This commit adds a new Docusaurus-based documentation site with:

### Guides Section:
- **Integrating with Testing Frameworks:** Overview of Copilot's capabilities.
- **Technical Overview:** Adapted from Detox docs (to be removed there).
- **Best Practices:** Framework-agnostic step-by-step guidance.
- **Custom Driver Implementation:** Guide to creating and adding testing framework drivers.
- **Contributing:** Details on adding prompt handlers and drivers, with tips and github link.

### API Section:
- **Interface Overview:** Lifecycle commands (`init`, `start`, `perform`, `end`).
- **Prompt Handlers:** Writing and contributing (`src/prompt-handlers`).
- **Framework Drivers:** Custom implementation, snapshot support, and type references.

### Showcase Page:
- Highlights Detox as the initial use case and invites collaboration with other frameworks.

chore: md and mdx files with the content of the website

chore: svg and icon files

chore: scss files

chore: feature changes and main page

Instead of Detox 6 features, now only 2 relevant features are presented. In addition, instead of the gif, we created fixed repetitive component.

css

fix: fix the side bar navigation

chore

chore: Changes due to code review

**Docusaurus leftovers were deleted.
**The link to edit the page was updated.
**The URL for the website was updated.
@asafkorem asafkorem merged commit fcdbd52 into master Jan 3, 2025
1 check passed
@asafkorem asafkorem deleted the copilot-doc-site branch January 3, 2025 12:24
@asafkorem
Copy link
Collaborator

Great job @LironMShemen! I will publish the site soon 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Docusaurus Site for Copilot by Detox Documentation
3 participants