-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak code signing lanes naming and make them all public #23991
Open
mokagio
wants to merge
9
commits into
trunk
Choose a base branch
from
mokagio/public_match_lanes
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, we can better code complete
Full name `update_certs_and_profiles_wordpress_enterprise`
Full name `update_certs_and_profiles_wordpress_app_store`
Full name `update_certs_and_profiles_jetpack_enterprise`
Full name `update_certs_and_profiles_jetpack_app_store`
This way, we can call them when it's time to regenerate the profiles for one single combination without hacking the `Fastfile`.
This will avoid API redirects
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done in the context of regenerating soon expiring certificates, see pdnsEh-1ZG-p2
I tweaked the name to be hierarchical. That is, the lane that updates everything is
update_certs_and_profiles
, the lane that updates all the WordPress variants isupdate_certs_and_profiles_wordpress
, the lane that update only the WordPress App Store variant isupdate_certs_and_profiles_wordpress_app_store
.I also made all lanes public, so they can be called individually, and added new lanes for updating both app's App Store or Enterprise code siging.
Testing
I run these locally as part of the certificates update work.
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary. N.A.UI changes testing checklist: Not a UI PR.