Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak code signing lanes naming and make them all public #23991

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jan 20, 2025

This was done in the context of regenerating soon expiring certificates, see pdnsEh-1ZG-p2

I tweaked the name to be hierarchical. That is, the lane that updates everything is update_certs_and_profiles, the lane that updates all the WordPress variants is update_certs_and_profiles_wordpress, the lane that update only the WordPress App Store variant is update_certs_and_profiles_wordpress_app_store.

I also made all lanes public, so they can be called individually, and added new lanes for updating both app's App Store or Enterprise code siging.

Testing

I run these locally as part of the certificates update work.

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

This way, we can better code complete
Full name `update_certs_and_profiles_wordpress_enterprise`
Full name `update_certs_and_profiles_wordpress_app_store`
Full name `update_certs_and_profiles_jetpack_enterprise`
Full name `update_certs_and_profiles_jetpack_app_store`
This way, we can call them when it's time to regenerate the profiles for
one single combination without hacking the `Fastfile`.
@mokagio mokagio requested a review from a team January 20, 2025 04:24
@mokagio mokagio self-assigned this Jan 20, 2025
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Jan 20, 2025
@mokagio mokagio added this to the Pending milestone Jan 20, 2025
@mokagio mokagio marked this pull request as ready for review January 20, 2025 04:25
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23991-4fac6d8
Version25.6
Bundle IDorg.wordpress.alpha
Commit4fac6d8
App Center BuildWPiOS - One-Offs #11369
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23991-4fac6d8
Version25.6
Bundle IDcom.jetpack.alpha
Commit4fac6d8
App Center Buildjetpack-installable-builds #10401
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants