Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exercise not being printed when an item from the menu is selected (issue #17) #19

Closed
wants to merge 1 commit into from

Conversation

chriptus13
Copy link

Fixed the problem with the exercise not being printed when an item from the menu is selected due to require being called in the wrong context. The error mentioned in the issue #17 still happens because of an error in the adventure package (fixed in version 2.11.2).

…e error mentioned in issue #17 still happens due to a bug on adventure (fixed in version 2.11.2) but now the exercise is printed when an item is selected from the menu
@ccarruitero
Copy link

Hi @chriptus13 ,

For me, the workshop is running correctly without changes.
What version of node and what OS do you use when notice the error with the require?

Aside, like you mention, this PR not attempt to resolve #17. So, do you mind to update the PR's title?

@chriptus13 chriptus13 closed this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants