Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBH multicall gas limit #113

Merged
merged 16 commits into from
Jan 7, 2025
Merged

PBH multicall gas limit #113

merged 16 commits into from
Jan 7, 2025

Conversation

karankurbur
Copy link
Contributor

@karankurbur karankurbur commented Jan 6, 2025

Add pbhGasLimit that is checked inside pbhMulticall

contracts/src/PBHEntryPointImplV1.sol Outdated Show resolved Hide resolved
contracts/src/PBHEntryPointImplV1.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@0xOsiris 0xOsiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can you update the DeployDevnet.s.sol script with the new initialization calldata, so this doesn't break CI.

@karankurbur karankurbur requested a review from 0xKitsune January 7, 2025 07:00
@karankurbur karankurbur force-pushed the karan-pbh-multicall-gas-limit branch from d0a1787 to 08c6094 Compare January 7, 2025 07:01
@karankurbur karankurbur merged commit 224069f into main Jan 7, 2025
5 checks passed
@karankurbur karankurbur deleted the karan-pbh-multicall-gas-limit branch January 7, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants