Skip to content

Commit

Permalink
Remove Choreo (#482)
Browse files Browse the repository at this point in the history
The Choreo team has requested it be removed from the installer, at least for 2025.

This reverts commit 778914a.
  • Loading branch information
spacey-sooty authored Dec 14, 2024
1 parent 3b518f6 commit 67643af
Show file tree
Hide file tree
Showing 12 changed files with 0 additions and 254 deletions.
2 changes: 0 additions & 2 deletions WPILibInstaller-Avalonia/Interfaces/IConfigurationProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ public interface IConfigurationProvider

AdvantageScopeConfig AdvantageScopeConfig { get; }

ChoreoConfig ChoreoConfig { get; }

ElasticConfig ElasticConfig { get; }

VsCodeConfig VsCodeConfig { get; }
Expand Down
14 changes: 0 additions & 14 deletions WPILibInstaller-Avalonia/Models/ChoreoConfig.cs

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ await ExtractArchive(token, new[] {
configurationProvider.JdkConfig.Folder + "/",
configurationProvider.UpgradeConfig.Tools.Folder + "/",
configurationProvider.AdvantageScopeConfig.Folder + "/",
configurationProvider.ChoreoConfig.Folder + "/",
configurationProvider.ElasticConfig.Folder + "/",
"installUtils/"});
}
Expand Down
13 changes: 0 additions & 13 deletions WPILibInstaller-Avalonia/ViewModels/StartPageViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -214,17 +214,6 @@ private async Task<bool> SelectResourceFilesWithFile(string file)
}) ?? throw new InvalidOperationException("Not Valid");
}

entry = zipArchive.GetEntry("choreoConfig.json");

using (StreamReader reader = new StreamReader(entry!.Open()))
{
var configStr = await reader.ReadToEndAsync();
ChoreoConfig = JsonConvert.DeserializeObject<ChoreoConfig>(configStr, new JsonSerializerSettings
{
MissingMemberHandling = MissingMemberHandling.Error
}) ?? throw new InvalidOperationException("Not Valid");
}

entry = zipArchive.GetEntry("elasticConfig.json");

using (StreamReader reader = new StreamReader(entry!.Open()))
Expand Down Expand Up @@ -436,8 +425,6 @@ public override PageViewModelBase MoveNext()

public AdvantageScopeConfig AdvantageScopeConfig { get; private set; } = null!;

public ChoreoConfig ChoreoConfig { get; private set; } = null!;

public ElasticConfig ElasticConfig { get; private set; } = null!;

public VsCodeConfig VsCodeConfig { get; private set; } = null!;
Expand Down
3 changes: 0 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ apply from: 'scripts/jdk.gradle'
apply from: 'scripts/maven.gradle'

apply from: 'scripts/advantagescope.gradle'
apply from: 'scripts/choreo.gradle'
apply from: 'scripts/elastic.gradle'

// Tools must happen after maven
Expand Down Expand Up @@ -223,7 +222,6 @@ def generateFullResourcesTask = tasks.register('generateFullResources', project.
jdkZipSetup(it)

advantageScopeZipSetup(it)
choreoZipSetup(it)
elasticZipSetup(it)

if (OperatingSystem.current().isWindows()) {
Expand Down Expand Up @@ -330,7 +328,6 @@ def generateConfigFiles = tasks.register('generateCommonResources', Zip) {
jdkConfigFileSetup(zip)

advantageScopeConfigFileSetup(zip)
choreoConfigFileSetup(zip)
elasticConfigFileSetup(zip)

vscodeConfigZipSetup(zip)
Expand Down
9 changes: 0 additions & 9 deletions files/Choreo.sh

This file was deleted.

45 changes: 0 additions & 45 deletions files/Choreo.vbs

This file was deleted.

27 changes: 0 additions & 27 deletions gradleriobase/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@ plugins {
id "edu.wpi.first.GradleRIO"
}

repositories {
mavenCentral()
maven {
url = uri("https://SleipnirGroup.github.io/ChoreoLib/dep")
}
}

deploy {
targets {
roborio(getTargetTypeClass('RoboRIO')) {
Expand Down Expand Up @@ -41,8 +34,6 @@ def deployCppArtifact = deploy.targets.roborio.artifacts.frcCpp

wpi.java.debugJni = false

def choreoVersion = "$choreoGitTag".substring(1)

dependencies {
annotationProcessor wpi.java.deps.wpilibAnnotations()
implementation wpi.java.deps.wpilib()
Expand Down Expand Up @@ -84,9 +75,6 @@ dependencies {
if (project(":").ext.buildClassifier == 'Windows') {
implementation "edu.wpi.first.msvc:runtime:${project(':gradleriobase').wpi.versions.wpilibVersion.get()}:x64@zip"
}

// choreo
implementation "choreo:ChoreoLib-java:$choreoVersion"
}

test {
Expand Down Expand Up @@ -125,20 +113,6 @@ nativeUtils {
}
}

nativeUtils {
nativeDependencyContainer {
choreo(getNativeDependencyTypeClass('WPISharedMavenDependency')) {
groupId = "choreo"
artifactId = "ChoreoLib-cpp"
headerClassifier = "headers"
sourceClassifier = "sources"
ext = "zip"
version = choreoVersion
targetPlatforms.addAll(nativeUtils.wpi.platforms.allPlatforms)
}
}
}

nativeUtils {
nativeDependencyContainer {
xrpvendordep(getNativeDependencyTypeClass('WPISharedMavenDependency')) {
Expand Down Expand Up @@ -181,7 +155,6 @@ model {
wpi.cpp.deps.googleTest(it)

wpi.cpp.deps.useLibrary(it, 'wpilibnewcommands')
wpi.cpp.deps.useLibrary(it, 'choreo')
wpi.cpp.deps.useLibrary(it, 'xrpvendordep')
wpi.cpp.deps.useLibrary(it, 'romivendordep')
}
Expand Down
121 changes: 0 additions & 121 deletions scripts/choreo.gradle

This file was deleted.

12 changes: 0 additions & 12 deletions scripts/maven.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,6 @@ def downloadNewCommands = tasks.register('downloadNewCommands', Download) {
overwrite false
}

def downloadChoreo = tasks.register('downloadChoreo', Download) {
src 'https://SleipnirGroup.github.io/ChoreoLib/dep/ChoreoLib2025Beta.json'
def fileName = file(src.file).name
dest "$buildDir/downloads/$fileName"
overwrite false
}

def downloadRomiVendor = tasks.register('downloadRomiVendor', Download) {
src 'https://raw.githubusercontent.com/wpilibsuite/allwpilib/main/romiVendordep/RomiVendordep.json'
def fileName = file(src.file).name
Expand All @@ -234,18 +227,13 @@ ext.mavenZipSetup = { AbstractArchiveTask zip->
}

zip.dependsOn downloadNewCommands
zip.dependsOn downloadChoreo
zip.dependsOn downloadReadTheDocs
zip.dependsOn downloadPythonAPI

zip.from(downloadNewCommands.get().outputFiles.first()) {
into '/vendordeps'
}

zip.from(downloadChoreo.get().outputFiles.first()) {
into '/vendordeps'
}

zip.from(downloadRomiVendor.get().outputFiles.first()) {
into '/vendordeps'
}
Expand Down
5 changes: 0 additions & 5 deletions scripts/tools.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,6 @@ def toolsJsonTask = tasks.register('toolsJson', Task) {
advantageScopeItem['version'] = advantagescopeGitTag
config << advantageScopeItem

def choreoItem = [:]
choreoItem['name'] = "Choreo"
choreoItem['version'] = choreoGitTag
config << choreoItem

def elasticItem = [:]
elasticItem['name'] = "Elastic"
elasticItem['version'] = elasticGitTag
Expand Down
2 changes: 0 additions & 2 deletions scripts/versions.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ ext.jdkVersion = '17.0.12+7'

ext.advantagescopeGitTag = 'v4.0.0-beta-3'

ext.choreoGitTag = 'v2025.0.0-beta-6'

ext.elasticGitTag = 'v2025.0.0-beta-4'

ext.frcYear = '2025'
Expand Down

0 comments on commit 67643af

Please sign in to comment.