Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epilogue] Add extra parentheses around cast when using varhandle #7428

Merged
merged 6 commits into from
Dec 7, 2024

Conversation

shueja
Copy link
Contributor

@shueja shueja commented Nov 23, 2024

No description provided.

@shueja shueja requested a review from a team as a code owner November 23, 2024 06:04
@shueja
Copy link
Contributor Author

shueja commented Nov 23, 2024

Closes #7427

SamCarlberg
SamCarlberg previously approved these changes Nov 23, 2024
Copy link
Member

@SamCarlberg SamCarlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs linting, but otherwise looks good

@shueja
Copy link
Contributor Author

shueja commented Nov 24, 2024

/format

Copy link
Contributor

@Gold856 Gold856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the warnings.

@SamCarlberg SamCarlberg merged commit f772bb1 into wpilibsuite:main Dec 7, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants