Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Remove statically linked JNI artifacts #7553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Dec 16, 2024

The loading framework for the -jni artifacts was removed in #6600, so these just don't work anymore. We can remove them to reduce the amount of space used when building and save some time as well (although the gains seem to be marginal).

Reference for CI build times and space savings: https://github.com/Gold856/allwpilib/actions/runs/12348391056

@Gold856 Gold856 requested review from a team as code owners December 16, 2024 13:39
@github-actions github-actions bot added component: ntcore NetworkTables library component: cscore CameraServer library component: apriltag AprilTag library labels Dec 16, 2024
@ThadHouse
Copy link
Member

The gains are marginal because how we do the building, these projects basically cost just a linking step. iirc they don't even compile anything, or if they do its 1 or 2 files.

Otherwise, I generally think I'm ok with this. You're right they're broken. They've also been broken for years anyway.

@Gold856 Gold856 force-pushed the remove-static-jni-artifacts branch from 71884f8 to 853459f Compare December 19, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: apriltag AprilTag library component: cscore CameraServer library component: ntcore NetworkTables library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants