Check for errors from requests.get (#2883)

wpilibsuite · Dec 23, 2024 · c0895b4 · c0895b4
1 parent c09391e
commit c0895b4
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/source/_extensions/wpilib_release.py b/source/_extensions/wpilib_release.py
@@ -24,6 +24,7 @@ def run(self) -> List[nodes.Node]:
 
         release_url = f"https://api.github.com/repos/wpilibsuite/allwpilib/releases/tags/{version}"
         release_json = requests.get(release_url)
+        release_json.raise_for_status()
         release: Dict = release_json.json()
 
         cf_folder = f"https://packages.wpilib.workers.dev/installer/{version}"
@@ -32,9 +33,9 @@ def run(self) -> List[nodes.Node]:
         )
 
         def get_url_size(osname):
-            soup = BeautifulSoup(
-                requests.get(f"{cf_folder}/{osname}/").text, "html.parser"
-            )
+            release_data = requests.get(f"{cf_folder}/{osname}/")
+            release_data.raise_for_status()
+            soup = BeautifulSoup(release_data.text, "html.parser")
             file = str(soup.find_all("tr")[-1].contents[0].string)
             size = str(soup.find_all("tr")[-1].contents[2].string)
             url_part = f"/{osname}/{file}"