-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block special character for project name #283
base: main
Are you sure you want to change the base?
Conversation
add special character validation (issue wpilibsuite#273 & wpilibsuite#63)
…vscode-wpilib into BlockSpecialCharacter
Does this only block it on the project name or also in the project path? There's also been instances of the later. I think it's too restrictive. For example underscore and hyphens are blocked. It might be better to block known bad characters then whitelist a limited subset. |
Then We need to set up a blacklist. The project name block strategies will be
The path block strategies will be
|
We can't block paths with white space too many users have a space in their username. The project name is the only one we need to block white space from |
I see. |
update project name and path valiadtion project name block strategies - string started with or ended with symbols are not allowed - string started with or ended with space are not allowed - string with blacklist character path block strategy: - path with blacklist character
update validators: space are not allowed in project name
add special character validation for project name
(issue #273 & #63)