Uses the Default CLI option to manage the UA list

.rubocop.yml

@@ -10,6 +10,8 @@ LineLength:
   Max: 120
 MethodLength:
   Max: 18
+  Exclude:
+    - app/controllers/core/cli_options.rb
 Lint/UriEscapeUnescape:
   Enabled: false
 Metrics/AbcSize:

app/controllers/core/cli_options.rb

@@ -46,7 +46,10 @@ def cli_browser_options
           OptBoolean.new(['--random-user-agent', '--rua',
                           'Use a random user-agent for each scan']),
           OptFilePath.new(['--user-agents-list FILE-PATH',
-                           'List of agents to use with --random-user-agent'], exists: true, advanced: true),
+                           'List of agents to use with --random-user-agent'],
+                          exists: true,
+                          advanced: true,
+                          default: APP_DIR.join('user_agents.txt')),
           OptCredentials.new(['--http-auth login:password']),
           OptPositiveInteger.new(['-t', '--max-threads VALUE', 'The max threads to use'],
                                  default: 5),

lib/cms_scanner/browser/options.rb

@@ -62,6 +62,8 @@ def user_agents
 
       @user_agents = []
 
+      # The user_agents_list is managed by the CLI options, with the default being
+      # APP_DIR/user_agents.txt
       File.open(user_agents_list).each do |line|
         next if line == "\n" || line[0, 1] == '#'
 
@@ -71,11 +73,6 @@ def user_agents
       @user_agents
     end
 
-    # @return [ String ] The path to the user agents list
-    def user_agents_list
-      @user_agents_list ||= File.join(APP_DIR, 'user_agents.txt')
-    end
-
     # @param [ value ] The throttle time in milliseconds
     #
     # if value > 0, the max_threads will be set to 1

spec/lib/browser_spec.rb

@@ -81,8 +81,6 @@
           expected = case sym
                      when :user_agent
                        browser.default_user_agent
-                     when :user_agents_list
-                       File.join(CMSScanner::APP_DIR, 'user_agents.txt')
                      when :throttle
                        0.0
                      end
@@ -219,8 +217,11 @@ class Browser
     context 'when --random-user-agent' do
       let(:options) { super().merge(random_user_agent: true) }
 
-      it 'select a random UA in the user_agents' do
+      it 'selects a random UA in the user_agents' do
+        expect(browser).to receive(:user_agents_list).and_return(FIXTURES.join('user_agents.txt'))
+
         expect(browser.user_agent).to_not eql browser.default_user_agent
+
         # Should not pick up a random one each time
         expect(browser.user_agent).to eql browser.user_agent
       end