Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlayerJS: Refactor to render module templates #2182

Merged
merged 1 commit into from
Oct 25, 2023
Merged

PlayerJS: Refactor to render module templates #2182

merged 1 commit into from
Oct 25, 2023
+7 −6

Conversation

rubenberttpingol
Copy link
Contributor

relates to xibosignageltd/xibo-private#505

@rubenberttpingol rubenberttpingol self-assigned this Oct 25, 2023
maurofmferrao
maurofmferrao approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rubenberttpingol
Copy link
Contributor Author

I have not refactored initStaticTemplates anymore by separating the ones for module as they almost have the same code to use. The only difference is just the $template to use when it's a module.

@rubenberttpingol rubenberttpingol merged commit bb46f3b into xibosignage:develop Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurofmferrao maurofmferrao maurofmferrao approved these changes

Assignees

@rubenberttpingol rubenberttpingol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubenberttpingol @maurofmferrao