Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Real time data pt1 #2269

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Real time data pt1 #2269

merged 8 commits into from
Dec 13, 2023

Conversation

dasgarner
Copy link
Member

@dasgarner dasgarner commented Dec 12, 2023 •
edited
Loading

Foundational work for data connectors and real time data.

  • DataSet extended with "Is Real Time" option and JavaScript
  • Scheduled extended with "Data Connector" event type and dataSetId/dataSetParams
  • XMDS extended to make both of the above available

@dasgarner
Bump version and set build container, etc.
09ea0ce
@dasgarner
Basic add/edit for data connector.
dd86a9a
@dasgarner
Update schedule forms for data connector.
1abd3e6 
Feature check for real time dataset add/edit.
DataSet params for Data Connector event.
XMDS work to supply these to the player
@dasgarner dasgarner self-assigned this Dec 12, 2023
@dasgarner dasgarner requested a review from PeterMis December 13, 2023 08:29
@dasgarner dasgarner marked this pull request as ready for review December 13, 2023 08:29
PeterMis
PeterMis requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@PeterMis PeterMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment/request please - funny enough not directly related to the work with real time data ;)

views/schedule-form-add.twig Outdated Show resolved Hide resolved
@dasgarner dasgarner requested a review from PeterMis December 13, 2023 13:42
@dasgarner
Copy link
Member Author

TEST: /Schedule, /Campaign END

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/7196098774

@dasgarner
Copy link
Member Author

TEST: /Schedule, /Campaign END

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/7196801594

@dasgarner
Copy link
Member Author

TEST: /Schedule, /Campaign END

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/7196813226

@dasgarner
Copy link
Member Author

TEST: /Schedule, /Campaign END

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/7196847296

@dasgarner
Copy link
Member Author

TEST: /Schedule, /Campaign END

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/7196927732

@dasgarner
Copy link
Member Author

TEST: /Schedule, /Campaign END

@github-actions GitHub Actions
Copy link

Test Suite: succeeded ✅
https://github.com/xibosignage/xibo-cms/actions/runs/7197027718

@dasgarner dasgarner merged commit 59f0ce3 into xibosignage:giacobini Dec 13, 2023
1 check passed
@dasgarner dasgarner deleted the giacobini/real_time_data_pt1 branch December 13, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterMis PeterMis PeterMis approved these changes

Assignees

@dasgarner dasgarner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dasgarner @PeterMis